Skip to content

Link to the online version of CLA in README.md - #463

Merged
thinkingserious merged 3 commits into
sendgrid:masterfrom
bharatr21:patch-1
Oct 5, 2018
Merged

Link to the online version of CLA in README.md#463
thinkingserious merged 3 commits into
sendgrid:masterfrom
bharatr21:patch-1

Conversation

@bharatr21

@bharatr21 bharatr21 commented Oct 1, 2018

Copy link
Copy Markdown
Contributor

Link to a directly signable, online version of CLA instead of a copy of the CLA for convenience

Fixes #462

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Links to a signable, online version of the CLA instead of a copy to the CLA which can't be signed directly

@bharatr21
Link to the online version of CLA in README.md
18d1dce 
Link to signable online version of CLA instead of a copy of the CLA for convenience
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 1, 2018
@bharatr21 bharatr21 mentioned this pull request Oct 1, 2018
Closed
thinkingserious
thinkingserious requested changes Oct 2, 2018
View reviewed changes
Comment thread README.md Outdated
- [Feature Request](https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#feature-request)
- [Bug Reports](https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#submit-a-bug-report)
- [Sign the CLA to Create a Pull Request](https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#cla)
- [Sign the CLA to Create a Pull Request](https://cla.sendgrid.com/sendgrid/sendgrid-java)

@thinkingserious thinkingserious Oct 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sort this list alphabetically please. Thanks!

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 2, 2018
@bharatr21

bharatr21 commented Oct 3, 2018

Copy link
Copy Markdown
Contributor Author

Fixed email mention and alphabetical order

@thinkingserious thinkingserious added hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: waiting for feedback waiting for feedback from the submitter labels Oct 5, 2018
@thinkingserious

thinkingserious commented Oct 5, 2018

Copy link
Copy Markdown
Contributor

Hello @Bharat123rox,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
thinkingserious merged commit ed13646 into sendgrid:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Link to online version of CLA instead of a copy of the CLA

2 participants

@bharatr21 @thinkingserious